Rename prepare_transaction() to prepare_send_outputs() #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
previously approved these changes
Mar 5, 2024
How is this different to sending accounts/NFTs? |
|
Well in those cases you are transferring ownership of the IDs, but that's not true with outputs. |
DaughterOfMars
previously approved these changes
Mar 5, 2024
Thoralf-M
dismissed stale reviews from DaughterOfMars and thibault-martinez
via
15f4e41
DaughterOfMars
approved these changes
Mar 5, 2024
thibault-martinez
approved these changes
Mar 5, 2024
Thoralf-M
deleted the
rename-prepare_transaction()-to-prepare_send_outputs()
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename so it's more aligned with our other methods